Fix S3878 FP: When input array is collection expression with spread operator#8970
Merged
zsolt-kolbay-sonarsource merged 1 commit intomasterfrom Mar 21, 2024
Merged
Fix S3878 FP: When input array is collection expression with spread operator#8970zsolt-kolbay-sonarsource merged 1 commit intomasterfrom
zsolt-kolbay-sonarsource merged 1 commit intomasterfrom
Conversation
|
|
||
| // repro for https://github.com/SonarSource/sonar-dotnet/issues/8510 | ||
| _ = new MyClass(1, [a, .. array]); // Noncompliant FP | ||
| _ = new MyClass(1, [a, .. array]); // Compliant |
Contributor
Author
There was a problem hiding this comment.
Fixed
|
|
||
| _ = new MyClass4(class1, new(1, [1, .. array])); // Compliant | ||
| _ = new MyClass4([class1, new(1, [1, .. array])]); // Noncompliant, outer collection raises, despite the nested spread operator | ||
| // ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
Contributor
Author
There was a problem hiding this comment.
This case is why I do expression.Elements instead of expression.DescendantNodes()
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8510